-
Notifications
You must be signed in to change notification settings - Fork 37
feat(pgadmin): add new module for pgAdmin #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I went to test this module. It was having issues with installation, and the app was not being proxied. I forked the registry and made a branch to see if I can understand what is going wrong here. The main things that I changed on my side to get this working, was I introduced a variable for the pgadmin config, introduced locals to do joins and formatting, and I utilized the venv for pgadmin. I then added a step to write the configuration to a file so that pgadmin loads with the ideal settings for coder. Here is the fork if you would like to take a look. https://github.com/DevelopmentCats/registry/tree/cat/AJ0070-pgadmin-fix/registry/AJ0070 |
Thanks for the details! |
Thank you so much for taking the time to test the module and provide such detailed feedback. I really appreciate you forking the repository and creating a working example it was incredibly helpful for understanding the issues with installation and proxying. Please let me know @DevelopmentCats if that's okay with you. Thanks again for your help! |
No worries. That's totally fine with me. I'm happy to provide in whatever way I can. Sorry I couldn't point out the exact issues right out of the gate. I had never really worked with pgadmin-web before now and it took me a minute to get it myself lol. |
Thanks for the confirmation! |
I've implemented the changes. Let me know if there's anything else you'd like adjusted. |
@AJ0070, please link a video demo of the module wokring in a Coder workspace. Thanks, |
I'll do that right after I fix the workflow failure. |
pg-admin-test.mp4 |
@DevelopmentCats, could you please review the recent changes when you have a moment? |
Hey @AJ0070. that video doesn't show pgadmin with coder. the agent doesn't start and there is no pgadmin button in the dashboard |
Closes #36
Description
This pull request introduces a new Coder module for
pgAdmin
. This module allows users to easily add a pgAdmin web interface to their workspaces for managing PostgreSQL databases.pgAdmin
module under theAJ0070
namespace.main.tf
file to define the Coder app and script resources.run.sh
script to handle the installation and launch of pgAdmin.README.md
with usage instructions and prerequisites.main.test.ts
to ensure the module loads correctly.Type of Change
Module Information
Path:
registry/AJ0070/modules/pgadmin
New version:
v1.0.0
Breaking change: [ ] Yes [x] No
Testing & Validation
bun test
)bun run fmt
)/claim #36